Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(http/unstable): make info parameter optional #5652

Merged
merged 1 commit into from
Aug 7, 2024
Merged

fix(http/unstable): make info parameter optional #5652

merged 1 commit into from
Aug 7, 2024

Conversation

iuioiua
Copy link
Contributor

@iuioiua iuioiua commented Aug 7, 2024

This makes the parameter compatible with deno serve, which was the original intention of route().

@iuioiua iuioiua requested a review from kt3k as a code owner August 7, 2024 13:10
@iuioiua iuioiua enabled auto-merge (squash) August 7, 2024 13:10
@github-actions github-actions bot added the http label Aug 7, 2024
@kt3k kt3k changed the title fix(http): make info parameter fix(http/unstable): make info parameter optional Aug 7, 2024
kt3k
kt3k approved these changes Aug 7, 2024
View reviewed changes
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iuioiua iuioiua merged commit 32ece25 into main Aug 7, 2024
12 checks passed
@iuioiua iuioiua deleted the http-route-info branch August 7, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kt3k kt3k kt3k approved these changes

Assignees
No one assigned
Labels
http
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iuioiua @kt3k