Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(crypto): upgrade dependencies #4530

Merged
merged 5 commits into from
Mar 28, 2024
Merged

chore(crypto): upgrade dependencies #4530

merged 5 commits into from
Mar 28, 2024

Conversation

iuioiua
Copy link
Contributor

@iuioiua iuioiua commented Mar 27, 2024

No description provided.

@iuioiua iuioiua requested a review from kt3k as a code owner March 27, 2024 23:45
@iuioiua iuioiua changed the title docs(fs): polish documentation (#4526) chore(crypto): upgrade dependencies Mar 27, 2024
@iuioiua iuioiua mentioned this pull request Mar 27, 2024
Closed
@iuioiua
Copy link
Contributor Author

iuioiua commented Mar 28, 2024

@dsherret, do you know what this error is? https://github.com/denoland/deno_std/actions/runs/8460137322/job/23177768638?pr=4530

@dsherret
Copy link
Member

Try just running cargo build in the directory.

@iuioiua
Copy link
Contributor Author

iuioiua commented Mar 28, 2024

I did - no files changed.

dsherret added 4 commits March 27, 2024 20:25
@dsherret
Try this.
7d0f73c
@dsherret
bad name
677f164
@dsherret
Revert "bad name"
8b5b9bb 
This reverts commit 677f164.

Revert "Try this."

This reverts commit 7d0f73c.
@dsherret
try this
83f093d
@dsherret
Copy link
Member

Seems like it was just a rust toolchain version mismatch

@iuioiua
Copy link
Contributor Author

iuioiua commented Mar 28, 2024

😅 Thanks. LGTM.

dsherret
dsherret approved these changes Mar 28, 2024
View reviewed changes
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iuioiua iuioiua merged commit bcfc7e0 into main Mar 28, 2024
11 checks passed
@iuioiua iuioiua deleted the update-crypto-deps branch March 28, 2024 02:24
eryue0220 added a commit to eryue0220/deno_std that referenced this pull request Mar 30, 2024
@eryue0220
Merge branch 'feat/expect-addSnapshotSerializer' of github.com:eryue0…
5ef840f 
…220/deno_std into feat/expect-addSnapshotSerializer

* 'feat/expect-addSnapshotSerializer' of github.com:eryue0220/deno_std:
  deprecation(crypto): rename an export to match style guide, deprecating original and two other obsolete imports (denoland#4525)
  chore: add `--allow-dirty` flag to publish dry run (denoland#4535)
  [unstable] BREAKING(semver): remove comparator.semver field (denoland#4533)
  chore(crypto): upgrade dependencies (denoland#4530)
  0.221.0 (denoland#4531)
  docs(fs): polish documentation (denoland#4526)
  fix(fs): `SubdirectoryMoveError` extends `Error` correctly (denoland#4528)
  chore(fs): remove `test.ts` (denoland#4527)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsherret dsherret dsherret approved these changes

@kt3k kt3k Awaiting requested review from kt3k kt3k is a code owner

Assignees
No one assigned
Labels
crypto
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iuioiua @dsherret