Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: refactor lint:mod-exports task to use std/path #4503

Merged
merged 11 commits into from
Mar 25, 2024

Conversation

iuioiua
Copy link
Contributor

@iuioiua iuioiua commented Mar 18, 2024

This fixes #4494 by delegating path-related logic to std/path, which takes the current OS into account. It also runs the lint workflow on other platforms besides Ubuntu to catch these issues earlier.

@iuioiua iuioiua marked this pull request as ready for review March 18, 2024 22:27
@iuioiua iuioiua requested a review from kt3k as a code owner March 18, 2024 22:27
@iuioiua iuioiua changed the title experiment: troubleshoot #4494 chore: refactor lint:mod-exports task to use std/path Mar 18, 2024
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iuioiua iuioiua merged commit 5061ec3 into main Mar 25, 2024
12 checks passed
@iuioiua iuioiua deleted the troubleshoot-windows-lint branch March 25, 2024 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

const stat of fs/exists.ts:69 is incorrect when running check_mod_exports.ts
2 participants