feat(cli): make Spinner.message able to be changed on-the-fly

[timreichen]

• makes Spinner.message property public

Reason: Allows to change message during active spinner.

Example:

import { Spinner } from "https://deno.land/std@$STD_VERSION/cli/spinner.ts";
import { delay } from "https://deno.land/std@$STD_VERSION/async/delay.ts";

const spinner = new Spinner( { message: "Loading..." });
spinner.start();
await delay(1000);
spinner.message = "Almost done..."
await delay(1000);
spinner.stop();

[iuioiua]

I like the idea of this. Thank you.

It does make me think that this same change could be applied to some of the other properties.

[timreichen]

I like the idea of this. Thank you.

It does make me think that this same change could be applied to some of the other properties.

Like color and interval?

[iuioiua]

Yep 👍🏾

[timreichen]

Yep 👍🏾

Should that be part of this PR or a separate one?

[iuioiua]

Let's have it part of this one.

[timreichen]

Actually, interval might need special treatment, else a change won't do anything.

[timreichen]

Ok, I updated the code so it works when changing interval and color while the spinner is running.
While at it, I removed the obsolete #active prop and made some adjustments for better readability.

Example:

import { Spinner } from "https://deno.land/std@$STD_VERSION/cli/spinner.ts";
import { delay } from "https://deno.land/std@$STD_VERSION/async/delay.ts";

const spinner = new Spinner({ message: "Loading..." });
spinner.start();
await delay(1000);
spinner.message = "Almost done...";
spinner.color = "blue";
spinner.interval = 25;
await delay(1000);
spinner.stop();

[iuioiua]

Frankly, I don't get some of these changes. I didn't think making color and friends would introduce such logic.

Sorry to change my mind, but can we revert to focusing on making Spinner.message public? Sorry for my previous suggestion. We should always keep PRs focused.

[iuioiua]

What's the purpose of this change?

[timreichen]

Frankly, I don't get some of these changes. I didn't think making color and friends would introduce such logic.

Sorry to change my mind, but can we revert to focusing on making Spinner.message public? Sorry for my previous suggestion. We should always keep PRs focused.

Ok, I reverted the changes and will open other PRs for the color and interval. There are some catches to be aware of so it works as intended, so the changes are not just to remove the hash.

[iuioiua]

Nice! LGTM. Thank you.