feat: Add v8::CompiledWasmModule
#776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In order for |
added 2 commits
September 13, 2021 13:17
`v8::CompiledWasmModule` is a representation of a compiled WebAssembly module, which can be shared by multiple `v8::WasmModuleObject`s. Closes denoland#759.
291ff09 to
29b601e
Compare
ry
reviewed
Sep 17, 2021
ry
reviewed
Sep 17, 2021
| let foo_bs = foo_ab.get_backing_store(); | ||
| let foo_section = unsafe { | ||
| std::slice::from_raw_parts(foo_bs.data() as *mut u8, foo_bs.byte_length()) | ||
| }; |
There was a problem hiding this comment.
Maybe just do the conversation to string in JavaScript?
let ab = WebAssembly.Module.customSections(module, 'foo')[0];
let ui8 = new Uint8Array(ab);
new TextDecoder().decode(ui8)
There was a problem hiding this comment.
TextDecoder is a web API, not a v8 built-in.
ry
reviewed
Sep 17, 2021
|
|
||
| // TODO(andreubotella): Safety??? | ||
| unsafe impl Send for CompiledWasmModule {} | ||
| unsafe impl Sync for CompiledWasmModule {} |
There was a problem hiding this comment.
I'm not sure about this either. If you don't need it, can we leave them out for now?
There was a problem hiding this comment.
They're gonna be needed for denoland/deno#11823 though.
ry
reviewed
Sep 17, 2021
ry
approved these changes
Sep 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v8::CompiledWasmModuleis a representation of a compiled WebAssembly module, which can be shared by multiplev8::WasmModuleObjects.Closes #759.