Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use seek and get the next code point #37

Merged
merged 2 commits into from
Jan 28, 2023
Merged

Use seek and get the next code point #37

merged 2 commits into from
Jan 28, 2023

Conversation

woxtu
Copy link
Contributor

@woxtu woxtu commented Jan 28, 2023 •
edited by crowlKats
Loading

Hi,

This PR makes the tokenizer implementation closely to the spec.

Ref: whatwg/urlpattern#124

crowlKats
crowlKats approved these changes Jan 28, 2023
View reviewed changes
Copy link
Member

@crowlKats crowlKats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@crowlKats crowlKats merged commit 23b343a into denoland:main Jan 28, 2023
@woxtu woxtu deleted the patch branch January 29, 2023 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crowlKats crowlKats crowlKats approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@woxtu @crowlKats