Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update to not use deprecated methods in index_map #371

Merged
merged 2 commits into from
Feb 1, 2024

Conversation

dsherret
Copy link
Member

@dsherret dsherret commented Feb 1, 2024

No description provided.

@dsherret dsherret requested a review from bartlomieju February 1, 2024 00:15
@@ -637,7 +637,7 @@ fn decode_with_charset(
let text = match text_encoding::convert_to_utf8(bytes.as_ref(), charset)? {
Cow::Borrowed(text) => {
if text.starts_with(text_encoding::BOM_CHAR) {
text[..text_encoding::BOM_CHAR.len_utf8()].to_string()
text[text_encoding::BOM_CHAR.len_utf8()..].to_string()
Copy link
Member Author

@dsherret dsherret Feb 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also found this critical bug fix in my working tree that I forgot to commit, so good this happened. All tests pass in CLI repo after this.

@dsherret dsherret merged commit dbd6eeb into denoland:main Feb 1, 2024
4 checks passed
@dsherret dsherret deleted the fix_index_map branch February 1, 2024 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants