Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: inspector changes for deno #938

Merged
merged 3 commits into from
Oct 23, 2024
Merged

refactor: inspector changes for deno #938

merged 3 commits into from
Oct 23, 2024

Conversation

devsnek
Copy link
Member

@devsnek devsnek commented Oct 22, 2024 •
edited
Loading

changes for denoland/deno#26471

  • allows passing a function which is called directly from the inspector to send messages, rather than going through a channel.
  • new modes for inspector sessions to support all the various ways a session interacts with the event loop

@devsnek devsnek marked this pull request as ready for review October 22, 2024 10:41
@devsnek devsnek requested a review from bartlomieju October 22, 2024 10:45
bartlomieju
bartlomieju approved these changes Oct 22, 2024
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice cleanup

@devsnek devsnek enabled auto-merge (squash) October 23, 2024 09:25
@devsnek devsnek merged commit 09219ca into main Oct 23, 2024
18 checks passed
@devsnek devsnek deleted the new-inspector branch October 23, 2024 09:53
@bartlomieju bartlomieju mentioned this pull request Nov 6, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@devsnek @bartlomieju