Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove AnyError case from CoreError and update deno_ast #1043

Merged
merged 7 commits into from
Jan 16, 2025

Conversation

crowlKats
Copy link
Member

No description provided.

@crowlKats crowlKats changed the title refactor: remove AnyError case from CoreError refactor: remove AnyError case from CoreError and update deno_ast Jan 10, 2025
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 49.20635% with 32 lines in your changes missing coverage. Please review.

Project coverage is 81.60%. Comparing base (0c7f83e) to head (5435fc3).
Report is 231 commits behind head on main.

Files with missing lines Patch % Lines
testing/checkin/runner/ts_module_loader.rs 42.85% 16 Missing ⚠️
core/modules/tests.rs 41.17% 10 Missing ⚠️
core/modules/loaders.rs 14.28% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1043      +/-   ##
==========================================
+ Coverage   81.43%   81.60%   +0.16%     
==========================================
  Files          97      102       +5     
  Lines       23877    27935    +4058     
==========================================
+ Hits        19445    22796    +3351     
- Misses       4432     5139     +707     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@crowlKats crowlKats merged commit be588b8 into denoland:main Jan 16, 2025
18 checks passed
@crowlKats crowlKats deleted the remove-anyerror-case branch January 16, 2025 16:09
crowlKats added a commit to denoland/deno that referenced this pull request Jan 17, 2025
crowlKats added a commit to denoland/deno that referenced this pull request Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants