-
Notifications
You must be signed in to change notification settings - Fork 108
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
This avoids substantial slowdowns caused by host objects using embedded fields. Depends on: denoland/rusty_v8#1322 Current status: For some reason v8::Symbol::for_global is returning a different symbol to the one defined in 01_core.js. ``` $ ./target/debug/deno test cli/tests/unit/message_channel_test.ts running 2 tests from ./cli/tests/unit/message_channel_test.ts messagechannel ... ok (35ms) messagechannel clone port ...result=Some(false) constructor=Object keys.length=0, identity hash:560437950 is_object false is_symbol true result=Some(false) constructor=MessagePort keys.length=4, identity hash:560437950 is_object false is_symbol true 0 symbol "Deno.core.customHostObject" is false, hash 253732785 is_object false is_symbol true 1 symbol "[[webidl.brand]]" is false, hash 764160415 is_object false is_symbol true 2 symbol "undefined" is false, hash 758685447 is_object false is_symbol true 3 symbol "id" is false, hash 997007839 is_object false is_symbol true Uncaught error from ./cli/tests/unit/message_channel_test.ts FAILED messagechannel clone port ... cancelled (0ms) ```
- Loading branch information
Showing
3 changed files
with
53 additions
and
11 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters