Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade: tokio 0.1 in test_util crate #8885

Merged
merged 7 commits into from
Jan 10, 2021
Merged

upgrade: tokio 0.1 in test_util crate #8885

merged 7 commits into from
Jan 10, 2021

Conversation

yos1p
Copy link
Contributor

@yos1p yos1p commented Dec 25, 2020 •
edited
Loading

This will upgrade test_util to tokio version 1.

This will also upgrade:

  • hyper to 0.14
  • tokio-rustls to 0.19
  • bytes to 1
  • tokio-tungstenite to 0.13

@yos1p yos1p mentioned this pull request Dec 25, 2020
Merged
@yos1p yos1p marked this pull request as ready for review January 10, 2021 05:09
@yos1p yos1p changed the title [WIP] upgrade: test_util to tokio 1 Upgrade: test_util to tokio 1 Jan 10, 2021
bartlomieju
bartlomieju approved these changes Jan 10, 2021
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @yos1p!

@bartlomieju bartlomieju changed the title Upgrade: test_util to tokio 1 upgrade: tokio 0.1 in test_util crate Jan 10, 2021
@bartlomieju bartlomieju merged commit 9e9e104 into denoland:master Jan 10, 2021
@yos1p yos1p deleted the testutil-tokio1 branch January 10, 2021 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yos1p @bartlomieju