-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] feat(cli): bundling using swc #7669
Conversation
I'm sorry but what should I do? |
@kdy1 nothing specifically at the moment other than thoughts and feedback... I need to add you as a co-author, and I will add you as a collaborator to my branch, but we were talking about it and because we were refactoring the whole of the compiler/module_graph/etc. it was easier for me to take your other PR and incorporate it. Obviously the bugs you were working on in swc are invaluable too... I am going to try to get more tests in, so we have more examples to validate things. I think we should really try to get it integrated and just try to fix whatever bugs we find. |
d84074d
to
0f8db54
Compare
Is stack overflow still reproducible? |
@kitsonk I confused passes. You have to apply Sorry for misleading. (I thought it is handled by typescrpit::strip, but it was not) Also, stack overflow of |
This has improved a lot (thanks @kdy1)... Still a couple challenges left:
|
Going to reland this under a different PR. |
This is very much still a WIP, but I have it working.
I adapted @kdy1's #7461 into the refactor of the module graph... I need to DRY up the code a bit, as well as provide type checking variant, as well are re-organise the code in the
main.rs
that shouldn't really be there. It does demonstrate how incongruent we handle stuff though, and all of this needs a really good scrub.Raising it now for review and discussion.