Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(lsp): ignore editor indent settings if deno.json is present #26912

Merged
merged 2 commits into from
Nov 18, 2024
Merged

fix(lsp): ignore editor indent settings if deno.json is present #26912

merged 2 commits into from
Nov 18, 2024

Conversation

nayeemrmn
Copy link
Collaborator

nathanwhit
nathanwhit approved these changes Nov 18, 2024
View reviewed changes
Copy link
Member

@nathanwhit nathanwhit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nayeemrmn nayeemrmn merged commit c36f877 into denoland:main Nov 18, 2024
17 checks passed
@nayeemrmn nayeemrmn deleted the lsp-editor-indent-settings-deprioritise branch November 19, 2024 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nathanwhit nathanwhit nathanwhit approved these changes

@dsherret dsherret Awaiting requested review from dsherret

@bartlomieju bartlomieju Awaiting requested review from bartlomieju

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

useTabs: true not respected when formatting via vscode deno extension
3 participants
@nayeemrmn @nathanwhit @bartlomieju