perf: use available system memory for v8 isolate memory limit #26868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We might also want to add an API like https://docs.libuv.org/en/v1.x/misc.html#c.uv_get_constrained_memory to respect cgroups on Linux, this is useful when running in a container. |
dsherret
reviewed
Nov 18, 2024
| /// Instead probe for the total memory on the system and use it instead | ||
| /// as a default. | ||
| pub fn create_isolate_create_params() -> Option<v8::CreateParams> { | ||
| let maybe_mem_info = deno_runtime::sys_info::mem_info(); |
There was a problem hiding this comment.
This seems very slow and negatively affects startup time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using the default 1.4Gb limit (which was meant for browser tabs) configure V8 to
set the heap limit to the amount of memory available in the system.
Closes #23424
Closes #26435
Closes #21226