Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(fmt/markdown): fix regression with multi-line footnotes and inline math #25222

Merged
merged 3 commits into from
Aug 26, 2024

Conversation

dsherret
Copy link
Member

What happened in this specific case was the parser used to actually treat these as code block. Now it treats it as a multi-paragraph footnote and that caused the issue

@dsherret dsherret requested a review from crowlKats August 26, 2024 17:23
@dsherret dsherret enabled auto-merge (squash) August 26, 2024 17:23
@dsherret dsherret changed the title fix(fmt/markdown): fix regression with multi-line footnotes fix(fmt/markdown): fix regression with multi-line footnotes and inline math Aug 26, 2024
@dsherret dsherret disabled auto-merge August 26, 2024 17:57
@dsherret dsherret enabled auto-merge (squash) August 26, 2024 17:58
@dsherret dsherret merged commit 631d931 into denoland:main Aug 26, 2024
17 checks passed
@dsherret dsherret deleted the fix_fmt_markdown_multiline_footnotes branch August 27, 2024 05:19
lucacasonato pushed a commit that referenced this pull request Aug 29, 2024
…e math (#25222)

What happened in this specific case was the parser used to actually
treat these as code block. Now it treats it as a multi-paragraph
footnote and that caused the issue

- https://github.com/dprint/dprint-plugin-markdown/pull/121/files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants