Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ext/node): cp into non-existent parent directory #23469

Merged
merged 1 commit into from
Apr 20, 2024
Merged

fix(ext/node): cp into non-existent parent directory #23469

merged 1 commit into from
Apr 20, 2024

Conversation

littledivy
Copy link
Member

Fixes #20604

@littledivy littledivy requested a review from satyarohith April 20, 2024 04:42
@littledivy littledivy mentioned this pull request Apr 20, 2024
Closed
satyarohith
satyarohith approved these changes Apr 20, 2024
View reviewed changes
Copy link
Member

@satyarohith satyarohith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I'm curious why these tests and the file in ext/fs is prefixed with std_

@littledivy
Copy link
Member Author

std_fs.rs means fs interface implemented using Rust's std. _fs prefix is probably old deno_std convention

@littledivy littledivy enabled auto-merge (squash) April 20, 2024 05:16
@littledivy littledivy merged commit 04c6785 into denoland:main Apr 20, 2024
17 checks passed
@littledivy littledivy deleted the node_fs_cp_dir branch April 20, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@satyarohith satyarohith satyarohith approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support SolidStart (SolidJS/Vite based)
2 participants
@littledivy @satyarohith