Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(cli): move op sanitizer to Rust #22413

Merged
merged 1 commit into from
Feb 16, 2024
Merged

Conversation

mmastrac
Copy link
Contributor

@mmastrac mmastrac commented Feb 14, 2024

The format of the sanitizers will change a little bit:

  • If multiple async ops leak and traces are on, we repeat the async op header once per stack trace.
  • All leaks are aggregated under a "Leaks detected:" banner as the new timers are eventually going to be added, and these are neither ops nor resources.
  • 1 async op is now An async op
  • If ops and resources leak, we show both (rather than op leaks masking resources)

Follow-on to #22226

@mmastrac mmastrac changed the title refactor(cli): move op sanitizer to Rust [WIP] refactor(cli): move op sanitizer to Rust Feb 15, 2024
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@mmastrac mmastrac force-pushed the op_sanitizer branch 2 times, most recently from c8bf302 to 999003f Compare February 16, 2024 15:44
mmastrac added a commit that referenced this pull request Feb 16, 2024
Moving tests around so that we can make #22413 smaller
@mmastrac mmastrac enabled auto-merge (squash) February 16, 2024 18:24
@mmastrac mmastrac merged commit 67a4231 into denoland:main Feb 16, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants