feat(runtime): add optional custom dns resolver to worker options #22293
Conversation
cli/Cargo.toml
Outdated
| @@ -155,6 +155,7 @@ http.workspace = true | |||
| http-body-util.workspace = true | |||
| hyper.workspace = true | |||
| hyper-util.workspace = true | |||
| hyper_v014.workspace = true | |||
There was a problem hiding this comment.
We shouldn't need to add this dep -- if we need anything from hyper_v014, we should re-export those bits from ext/fetch.
There was a problem hiding this comment.
Just exported Name from deno_fetch. Should it be in a dns module or something, so that it indicate it relates to DNS?
ext/kv/remote.rs
Outdated
| @@ -127,6 +129,7 @@ impl<P: RemoteDbHandlerPermissions + 'static> DatabaseHandler | |||
| let options = &self.http_options; | |||
| let client = create_http_client( | |||
| &options.user_agent, | |||
| options.dns_resolver.clone(), | |||
There was a problem hiding this comment.
On second thought -- maybe this should live on CreateHttpClientOptions?
I think it's fine to require a debug bound on the resolver. If we run into trouble with that, we should create our own intermediate trait and export that from ext/fetch instead.
There was a problem hiding this comment.
I went with a struct instead of a trait (DnsResolver), and implemented Debug. A trait seemed kind of overkill, idk. Wdyt?
cli/file_fetcher.rs
Outdated
| _name: hyper_v014::client::connect::dns::Name, | ||
| ) -> Resolving { | ||
| let iter: Box<dyn Iterator<Item = SocketAddr> + Send> = Box::new( | ||
| vec!["127.0.0.1:0".parse::<SocketAddr>().unwrap()].into_iter(), |
There was a problem hiding this comment.
Just return an Ipv4Addr::LOCALHOST here
Co-authored-by: Matt Mastracci <matthew@mastracci.com> Signed-off-by: Primož Erjavec <primoze@users.noreply.github.com>
…into fetch-dns-resolver
|
I'm going to close this one for now. Please ping me if you'd like to revive it. |
This implements #17165.
It allows specifying a custom DNS resolver in
WorkerOptions(andWebWorkerOptions), which is then used when creatingOptionsfor the fetch API, andHttpOptionsfor the KV remote DB handler.Supersedes #17166, as it seems abandoned (and deno has changed a lot since then).
I changed the
deno_fetch::create_http_clientsignature, because adding the resolver toCreateHttpClientOptionswould require a+ Debugtrait bound.