Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lsp): complete parameters as tab stops and placeholders #22126

Merged

Conversation

nayeemrmn
Copy link
Collaborator

Fixes denoland/vscode_deno#1036.

When you have "typescript.suggest.completeFunctionCalls": true and get completions with function parameters, now they are pre-highlighted and you can cycle through them with tab. See denoland/vscode_deno#1036 (comment) for a demo.

Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a way we could test this?

@nayeemrmn
Copy link
Collaborator Author

Is there a way we could test this?

The test change in this patch is doing so, ${1:<placeholder>} is the syntax for a tab stop.

@nayeemrmn nayeemrmn merged commit 9a5b4b0 into denoland:main Jan 26, 2024
14 checks passed
@nayeemrmn nayeemrmn deleted the lsp-complete-function-calls-tab-stops branch January 26, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When typescript.suggest.completeFunctionCalls is true, the string is inserted as is instead of a snippet
2 participants