feat(cli): improved diagnostics printing #22049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This initially uses the new diagnostic printer in `deno lint`, `deno doc` and `deno publish`. In the limit we should also update `deno check` to use this printer.
d4d82aa to
a560699
Compare
bartlomieju
approved these changes
Jan 23, 2024
| /// Returns the text of the line that contains the given positions, split at the | ||
| /// given positions. | ||
| /// | ||
| /// If the positions are on different lines, this will panic. |
There was a problem hiding this comment.
Is this okay? Maybe it should return an option and not panic?
There was a problem hiding this comment.
The caller ensures they are on the same line already.
| // error[missing-return-type]: missing explicit return type on public function | ||
| // at /mnt/artemis/Projects/github.com/denoland/deno/test.ts:1:16 | ||
| // | | ||
| // 1 | export function test() { |
There was a problem hiding this comment.
Do you think in the future we could syntax highlight this code?
Yeah, sounds good. It's a bit more involved because TS diagnostics can be "nested", so the printer needs to become a bit smarter. I attempted it briefly, but then realized that it would be too much work to do right away. I estimate 2-3 days of work to get it all perfect. |
bartlomieju
pushed a commit
to bartlomieju/deno
that referenced
this pull request
Jan 23, 2024
This initially uses the new diagnostic printer in `deno lint`, `deno doc` and `deno publish`. In the limit we should also update `deno check` to use this printer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This initially uses the new diagnostic printer in
deno lint,deno docanddeno publish. In the limit we should also updatedeno checkto use this printer.