feat: Start warning on each use of a deprecated API

cli/tests/integration/run_tests.rs

@@ -4939,3 +4939,10 @@ itest!(unstable_temporal_api_missing_flag {
   http_server: false,
   exit_code: 1,
 });
+
+itest!(warn_on_deprecated_api {
+  args: "run -A run/warn_on_deprecated_api/main.js",
+  output: "run/warn_on_deprecated_api/main.out",
+  http_server: true,
+  exit_code: 0,
+});

cli/tests/testdata/run/warn_on_deprecated_api/main.js

@@ -0,0 +1,32 @@
+import { runEcho as runEcho2 } from "http://localhost:4545/run/warn_on_deprecated_api/mod.ts";
+
+const p = Deno.run({
+  cmd: [
+    Deno.execPath(),
+    "eval",
+    "console.log('hello world')",
+  ],
+});
+await p.status();
+p.close();
+
+async function runEcho() {
+  const p = Deno.run({
+    cmd: [
+      Deno.execPath(),
+      "eval",
+      "console.log('hello world')",
+    ],
+  });
+  await p.status();
+  p.close();
+}
+
+await runEcho();
+await runEcho();
+
+for (let i = 0; i < 10; i++) {
+  await runEcho();
+}
+
+await runEcho2();

cli/tests/testdata/run/warn_on_deprecated_api/main.out

@@ -0,0 +1,72 @@
+Download http://localhost:4545/run/warn_on_deprecated_api/mod.ts
+Warning
+├ Use of deprecated "Deno.run()" API.
+│
+├ This API will be removed in Deno 2.0. Make sure to upgrade to a stable API before then.
+│
+├ Suggestion: Use "Deno.Command()" API instead.
+│
+└ Stack trace:
+  └─ at [WILDCARD]warn_on_deprecated_api/main.js:3:16
+
+hello world
+Warning
+├ Use of deprecated "Deno.run()" API.
+│
+├ This API will be removed in Deno 2.0. Make sure to upgrade to a stable API before then.
+│
+├ Suggestion: Use "Deno.Command()" API instead.
+│
+└ Stack trace:
+  ├─ at runEcho ([WILDCARD]warn_on_deprecated_api/main.js:14:18)
+  └─ at [WILDCARD]warn_on_deprecated_api/main.js:25:7
+
+hello world
+Warning
+├ Use of deprecated "Deno.run()" API.
+│
+├ This API will be removed in Deno 2.0. Make sure to upgrade to a stable API before then.
+│
+├ Suggestion: Use "Deno.Command()" API instead.
+│
+└ Stack trace:
+  ├─ at runEcho ([WILDCARD]warn_on_deprecated_api/main.js:14:18)
+  └─ at [WILDCARD]warn_on_deprecated_api/main.js:26:7
+
+hello world
+Warning
+├ Use of deprecated "Deno.run()" API.
+│
+├ This API will be removed in Deno 2.0. Make sure to upgrade to a stable API before then.
+│
+├ Suggestion: Use "Deno.Command()" API instead.
+│
+└ Stack trace:
+  ├─ at runEcho ([WILDCARD]warn_on_deprecated_api/main.js:14:18)
+  └─ at [WILDCARD]warn_on_deprecated_api/main.js:29:9
+
+hello world
+hello world
+hello world
+hello world
+hello world
+hello world
+hello world
+hello world
+hello world
+hello world
+Warning
+├ Use of deprecated "Deno.run()" API.
+│
+├ This API will be removed in Deno 2.0. Make sure to upgrade to a stable API before then.
+│
+├ Suggestion: Use "Deno.Command()" API instead.
+│
+├ Suggestion: It appears this API is used by a remote dependency.
+│             Try upgrading to the latest version of that dependency.
+│
+└ Stack trace:
+  ├─ at runEcho (http://localhost:4545/run/warn_on_deprecated_api/mod.ts:2:18)
+  └─ at [WILDCARD]warn_on_deprecated_api/main.js:32:7
+
+hello world

cli/tests/testdata/run/warn_on_deprecated_api/mod.ts

@@ -0,0 +1,11 @@
+export async function runEcho() {
+  const p = Deno.run({
+    cmd: [
+      Deno.execPath(),
+      "eval",
+      "console.log('hello world')",
+    ],
+  });
+  await p.status();
+  p.close();
+}

runtime/js/40_process.js

@@ -140,6 +140,11 @@ function run({
       ...new SafeArrayIterator(ArrayPrototypeSlice(cmd, 1)),
     ];
   }
+  internals.warnOnDeprecatedApi(
+    "Deno.run()",
+    (new Error()).stack,
+    `Use "Deno.Command()" API instead.`,
+  );
   const res = opRun({
     cmd: ArrayPrototypeMap(cmd, String),
     cwd,

runtime/js/99_main.js

@@ -9,6 +9,8 @@ const {
   ArrayPrototypeFilter,
   ArrayPrototypeIncludes,
   ArrayPrototypeMap,
+  ArrayPrototypePop,
+  ArrayPrototypeShift,
   DateNow,
   Error,
   ErrorPrototype,
@@ -23,6 +25,10 @@ const {
   ObjectValues,
   PromisePrototypeThen,
   PromiseResolve,
+  SafeSet,
+  StringPrototypeIncludes,
+  StringPrototypeSplit,
+  StringPrototypeTrim,
   Symbol,
   SymbolIterator,
   TypeError,
@@ -89,6 +95,88 @@ ObjectDefineProperties(Symbol, {
 let windowIsClosing = false;
 let globalThis_;
 
+const ALREADY_WARNED_DEPRECATED = new SafeSet();
+
+function warnOnDeprecatedApi(apiName, stack, suggestion) {
+  if (ALREADY_WARNED_DEPRECATED.has(apiName + stack)) {
+    return;
+  }
+
+  // If we haven't warned yet, let's do some processing of the stack trace
+  // to make it more useful.
+  const stackLines = StringPrototypeSplit(stack, "\n");
+  ArrayPrototypeShift(stackLines);
+  while (true) {
+    // Filter out internal frames at the top of the stack - they are not useful
+    // to the user.
+    if (
+      StringPrototypeIncludes(stackLines[0], "(ext:") ||
+      StringPrototypeIncludes(stackLines[0], "(node:")
+    ) {
+      ArrayPrototypeShift(stackLines);
+    } else {
+      break;
+    }
+  }
+  // Now remove the last frame if it's coming from "ext:core" - this is most likely
+  // event loop tick or promise handler calling a user function - again not
+  // useful to the user.
+  if (
+    StringPrototypeIncludes(stackLines[stackLines.length - 1], "(ext:core/")
+  ) {
+    ArrayPrototypePop(stackLines);
+  }
+
+  let isFromRemoteDependency = false;
+  const firstStackLine = stackLines[0];
+  if (firstStackLine && !StringPrototypeIncludes(firstStackLine, "file:")) {
+    isFromRemoteDependency = true;
+  }
+
+  ALREADY_WARNED_DEPRECATED.add(apiName + stack);
+  console.log(
+    "%cWarning",
+    "color: yellow; font-weight: bold;",
+  );
+  console.log(
+    `%c\u251c Use of deprecated "${apiName}" API.`,
+    "color: yellow;",
+  );
+  console.log("%c\u2502", "color: yellow;");
+  console.log(
+    "%c\u251c This API will be removed in Deno 2.0. Make sure to upgrade to a stable API before then.",
+    "color: yellow;",
+  );
+  console.log("%c\u2502", "color: yellow;");
+  console.log(
+    `%c\u251c Suggestion: ${suggestion}`,
+    "color: yellow;",
+  );
+  if (isFromRemoteDependency) {
+    console.log("%c\u2502", "color: yellow;");
+    console.log(
+      `%c\u251c Suggestion: It appears this API is used by a remote dependency.`,
+      "color: yellow;",
+    );
+    console.log(
+      "%c\u2502             Try upgrading to the latest version of that dependency.",
+      "color: yellow;",
+    );
+  }
+
+  console.log("%c\u2502", "color: yellow;");
+  console.log("%c\u2514 Stack trace:", "color: yellow;");
+  for (let i = 0; i < stackLines.length; i++) {
+    console.log(
+      `%c  ${i == stackLines.length - 1 ? "\u2514" : "\u251c"}\u2500 ${
+        StringPrototypeTrim(stackLines[i])
+      }`,
+      "color: yellow;",
+    );
+  }
+  console.log();
+}
+
 function windowClose() {
   if (!windowIsClosing) {
     windowIsClosing = true;
@@ -432,7 +520,7 @@ function exposeUnstableFeaturesForWindowOrWorkerGlobalScope(options) {
 // FIXME(bartlomieju): temporarily add whole `Deno.core` to
 // `Deno[Deno.internal]` namespace. It should be removed and only necessary
 // methods should be left there.
-ObjectAssign(internals, { core });
+ObjectAssign(internals, { core, warnOnDeprecatedApi });
 const internalSymbol = Symbol("Deno.internal");
 const finalDenoNs = {
   internal: internalSymbol,