feat: remove conditional unstable type-checking #21825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I wonder if we should remove all the code related to "unstable" from the LSP. Thoughts on that? |
bartlomieju
added a commit
to bartlomieju/deno
that referenced
this pull request
Jan 22, 2024
…enoland#21991) It appears I missed this in denoland#21825.
|
Does this change completely prevent the ability to type-check code that is intended to use only stable features (in order to detect invalid unstable references prior to runtime), or is there some alternative mechanism to do so? |
That's correct. Now all APIs are unconditionally type-checked. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes conditional type-checking of unstable APIs.
Before this commit
deno check(or any other type-checking command and the LSP)would error out if there was an unstable API in the code, but not
--unstableflagprovided.
This situation hinders DX and makes it harder to configure Deno. Failing during
runtime unless
--unstableflag is provided is enough in this case.