Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): respect exclude option for deno check command #21779

Merged

Conversation

nokazn
Copy link
Contributor

@nokazn nokazn commented Jan 3, 2024

This PR fixes #21658.

  • check subcommand sees exclude option in deno.json. When some paths passed with check command listed in exclude, they are ignored.
  • When some files are listed in exclude and imported indirectly among module graph, they are checked.

@CLAassistant
Copy link

CLAassistant commented Jan 3, 2024

CLA assistant check
All committers have signed the CLA.

@nokazn nokazn marked this pull request as ready for review January 3, 2024 20:17
@bartlomieju bartlomieju requested a review from dsherret January 3, 2024 22:03
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me once the formatting errors are fixed (run ./tools/format.js and ./tools/lint.js)

@nokazn
Copy link
Contributor Author

nokazn commented Jan 4, 2024

@dsherret
Sorry for missing. I fixed it by 6b7f093,

@nokazn nokazn requested a review from dsherret January 4, 2024 01:34
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@dsherret dsherret merged commit a0b6872 into denoland:main Jan 4, 2024
14 checks passed
@nokazn nokazn deleted the fix/#21658/respect-exclude-option-for-check branch January 4, 2024 01:53
bartlomieju pushed a commit that referenced this pull request Jan 4, 2024
This PR fixes #21658.

- `check` subcommand sees `exclude` option in `deno.json`. When some
paths passed with `check` command listed in `exclude`, they are ignored.
- When some files are listed in `exclude` and imported indirectly among
module graph, they are checked.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

deno check command doesn't respect exclude option in deno.json(c)
3 participants