Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new
--lint
flag todeno doc
that surfaces three kinds of diagnostics:@internal
jsdoc tag to the internal type.deno doc
will not display good documentation. Adding explicit types also helps with type checking performance.If the lint passes,
deno doc
generates documentation as usual.For example, checking for deno doc diagnostics on the CI:
$ deno doc --lint mod.ts second_entrypoint.ts > /dev/null
This feature is incredibly useful for library authors.
Why not include this in
deno lint
?deno lint
doesn't understand where the entrypoints are. That's critical for the diagnostics to be useful.#![warn(missing_docs)]
).Why not
--check
?It is confusing with
deno run --check
, since that means to run type checking (and confusing withdeno check --docs
).Output Future Improvement
The output is not ideal atm, but it's fine for a first pass. We will improve it in the future.
Closes denoland/deno_lint#972
Closes denoland/deno_lint#970
Closes #19356