fix(lsp): allow formatting vendor files #20844
Conversation
There was a problem hiding this comment.
Does deno fmt ./vendor/esm.sh/v124/@twind/core@1.1.3/deno/core.mjs from the issue work? I think maybe this doesn't close the issue entirely?
| .url_map | ||
| .normalize_url(¶ms.text_document.uri, LspUrlKind::File); | ||
| // skip formatting any files ignored by the config file | ||
| if !self.fmt_options.files.matches_specifier(&specifier) { |
There was a problem hiding this comment.
If someone ignores something in the vendor folder, will this also skip those files? I think probably not. Maybe it should?
There was a problem hiding this comment.
Currently vendor isn't applicable to config exclusion checks because it's excluded by default. We should remove https://github.com/denoland/deno_config/blob/0.4.0/src/lib.rs#L688-L690 for a start. It shouldn't be handled there.
|
We should change our fmt config exclusion check to only apply to automatic discovery such as |
|
I'm gonna land this for now and open more targeted issues for the remainders |
Fixes #20308.