Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ext/formdata): support multiple headers in FormData #20801

Merged
merged 2 commits into from
Oct 5, 2023
Merged

fix(ext/formdata): support multiple headers in FormData #20801

merged 2 commits into from
Oct 5, 2023

Conversation

marcosc90
Copy link
Contributor

fixes #20793

bartlomieju
bartlomieju approved these changes Oct 5, 2023
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strange that there's no WPT for it. Anyway, LGTM thanks for a quick fix Marcos!

@bartlomieju bartlomieju merged commit 176bf9b into denoland:main Oct 5, 2023
@marcosc90 marcosc90 deleted the fix-20793 branch October 5, 2023 17:29
@jimmywarting
Copy link
Contributor

Thanks for fixing it so fast

@marcosc90
Copy link
Contributor Author

Strange that there's no WPT for it. Anyway, LGTM thanks for a quick fix Marcos!

Thought the same! You're welcome!

bartlomieju pushed a commit that referenced this pull request Oct 12, 2023
@marcosc90 @bartlomieju
fix(ext/formdata): support multiple headers in FormData (#20801)
0fb5d2e 
Fixes #20793
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

parsing formdata headers incorrectly.
3 participants
@marcosc90 @jimmywarting @bartlomieju