fix(ext/node): implement uv.errname #20785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartlomieju
requested changes
Oct 4, 2023
|
I love to see these little compat bugs getting knocked out. Nice work @littledivy. Thank you for the bug report @birkskyum |
bartlomieju
approved these changes
Oct 5, 2023
|
@ry , glad to be helpful, I really didn't want to be spammy. Despite being very excited about Deno for years, I haven't been able to let go of Node for a single project, because virtually my entire stack is incompatible. Opening the door towards node compat made me hopeful that this could change, so i decided to screen Deno support for a big part of the landscape I find myself in. I'm quite confident that delivering on these tickets, as well as allowing opt-in to run postinstall for certain trusted npm deps (sharp, puppeteer etc.), would boost adoption in the front end space significantly. |
bartlomieju
pushed a commit
that referenced
this pull request
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20617