feat(jupyter): support Deno.test() #20778
Conversation
There was a problem hiding this comment.
There's quite a few moving parts here - would you be able to split this PR into two separate PRs so that if something goes wrong we can revert them in bite-sized chunks? I believe the refactor or tools/test to accept writer argument could be a standalone PR which would be a nice cleanup anyway. Would you be able to update cli/tests/testdata/jupyter/integration_tests.ipynb to include a cell that runs a test?
|
I am so excited about this because now we can give tutorials on writing tests within a notebook. 👨🏻🍳💋 |
| ops::jupyter::deno_jupyter::init_ops(stdio_tx.clone()), | ||
| crate::ops::testing::deno_test::init_ops(test_event_sender.clone()), | ||
| ], | ||
| // FIXME(nayeemrmn): Test output capturing currently doesn't work. |
There was a problem hiding this comment.
Hm, shouldn't we be able to capture the test output the same way deno test does it? Isn't it a matter of forwarding it to a proper channel?
There was a problem hiding this comment.
It causes all logged output in the repl to be buffered and then flushed to stdout at once when a test event is processed.
Blocked by #20783.