refactor(lsp): clean up tsc requests #20743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsherret
reviewed
Sep 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have two useless intermediate representation of requests between the
TsServer::<method>()args and the typescriptlanguageService[method]()args. Namely theRequestMethodenum and the 'serializations' returned byRequestMethod::to_value(), which still need to be parsed into the final TS API args. The latter also has type declarations incompiler.d.ts.So there are 4 different places in our tsc abstraction layer that need to be changed if I wanted to, say, add a new workspace setting and pass that into TSC.
This reduces that to 1. Now things like the specifier denormalization and normalization are near each other, and located at each respective
TsServermethod.