Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(upgrade): error instead of panic on unzip failure #20691

Merged
merged 2 commits into from
Sep 26, 2023
Merged

fix(upgrade): error instead of panic on unzip failure #20691

merged 2 commits into from
Sep 26, 2023

Conversation

dsherret
Copy link
Member

For #20683

@dsherret dsherret mentioned this pull request Sep 26, 2023
Closed
dsherret
dsherret commented Sep 26, 2023
View reviewed changes
@dsherret dsherret marked this pull request as draft September 26, 2023 18:56
@dsherret dsherret changed the title fix(upgrade): surface unpack zip failure fix(upgrade): error instead of panic on unzip failure Sep 26, 2023
@dsherret dsherret marked this pull request as ready for review September 26, 2023 19:02
@dsherret dsherret merged commit 91832ce into denoland:main Sep 26, 2023
@dsherret dsherret deleted the upgrade_output_unpack_failure branch September 26, 2023 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dsherret @bartlomieju