fix(ext/node): remove unnecessary and incorrect type priority_t #20276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
24f2184 to
b2db072
Compare
`getpriority` and `setpriority` on musl libc accepts `int` / `c_int` / `i32` as the first argument, not `u32`. Since the `PRIO_PROCESS` constant is imported from the same crate (libc) as the `getpriority` and `setpriority` functions, this type cast seems to be completely unnecessary here. It was introduced in aa8078b. Relevant sources: - https://github.com/rust-lang/libc/blob/835661543db1ec42a6d9a809d69c3c5b5b978b81/src/unix/linux_like/linux/musl/mod.rs#L739-L740 - https://git.musl-libc.org/cgit/musl/tree/src/misc/setpriority.c - https://git.musl-libc.org/cgit/musl/tree/src/misc/getpriority.c
9d3333f to
99e16c5
Compare
|
No, it’s not exactly the same issue and the resolution is different, that PR doesn’t fix the bug on musl libc |
|
@aapoalas could you take a look at this PR? |
aapoalas
approved these changes
Aug 30, 2023
There was a problem hiding this comment.
Looks good to me: I checked that at least all the most common freebsd, openbsd, musl and linux-gnu platform libc packages indeed match setpriority and PRIO_PROCESS types and thus as said, the type assert should be entirely unnecessary.
Thank you for the nice fix!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getpriorityandsetpriorityon musl libc acceptsint/c_int/i32as the first argument, notu32.Since the
PRIO_PROCESSconstant is imported from the same crate (libc) as thegetpriorityandsetpriorityfunctions, this type cast seems to be completely unnecessary here.It was introduced in aa8078b by @crowlKats.
Relevant sources: