fix(node): export punycode module #19151
Conversation
| NodeModulePolyfill { | ||
| name: "punycode", | ||
| specifier: "ext:deno_node/punycode.ts", | ||
| }, |
There was a problem hiding this comment.
The version of the punycode module bundled in Node.js is being deprecated. In a future major version of Node.js this module will be removed. Users currently depending on the punycode module should switch to using the userland-provided Punycode.js module instead.
Should we bother adding this if it's going to be deprecated?
There was a problem hiding this comment.
I think so, currently existing packages might still depend on it and it doesn't say when it will be removed. @kt3k thoughts?
There was a problem hiding this comment.
(and we already support it in CJS just not ESM)
There was a problem hiding this comment.
I'm fine with either way, but probably it's less confusing if we already provide it via cjs. I confirmed the below prints the punycode module without error:
import { createRequire } from "node:module";
console.log(createRequire(import.meta.url)("node:punycode"));
Closes #19147