Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ext/websocket): order of ws writes #19131

Merged
merged 2 commits into from
May 18, 2023
Merged

fix(ext/websocket): order of ws writes #19131

merged 2 commits into from
May 18, 2023

Conversation

littledivy
Copy link
Member

Fixes #19041

bartlomieju
bartlomieju requested changes May 15, 2023
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a test

bartlomieju
bartlomieju approved these changes May 18, 2023
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed offline, we're gonna merge it without a test right now to include it in v1.33.4 release and add a test later

@littledivy littledivy merged commit 6241a65 into denoland:main May 18, 2023
levex pushed a commit that referenced this pull request May 18, 2023
@littledivy @levex
fix(ext/websocket): order of ws writes (#19131)
b733910 
Fixes #19041
@bartlomieju bartlomieju deleted the fix_ws_order branch May 18, 2023 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

WebSocket dropping messages when many are sent
2 participants
@littledivy @bartlomieju