Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(runtime): Example hello_runtime panic #19125

Merged
merged 1 commit into from
May 14, 2023
Merged

fix(runtime): Example hello_runtime panic #19125

merged 1 commit into from
May 14, 2023

Conversation

yzy-1
Copy link
Contributor

@yzy-1 yzy-1 commented May 14, 2023

After commit f34fcd, running example will panic because esm_entry_point is not set.

Closes #19127

After commit f34fcd, running example will panic because esm_entry_point is not set.
@CLAassistant
Copy link

CLAassistant commented May 14, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@bartlomieju bartlomieju merged commit b99159b into denoland:main May 14, 2023
levex pushed a commit that referenced this pull request May 18, 2023
After commit f34fcd, running example will panic because esm_entry_point
is not set.

Closes #19127
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

deno_runtime hello_runtime.rs example is broken
3 participants