Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ext/kv): throw on the Kv constructor #18978

Merged
merged 2 commits into from
May 3, 2023
Merged

fix(ext/kv): throw on the Kv constructor #18978

merged 2 commits into from
May 3, 2023

Conversation

lucacasonato
Copy link
Member

Closes #18963

@lucacasonato lucacasonato requested a review from losfair May 3, 2023 19:13
bartlomieju
bartlomieju reviewed May 3, 2023
View reviewed changes
ext/kv/01_db.ts Outdated Show resolved Hide resolved
@bartlomieju bartlomieju merged commit d905f20 into denoland:main May 3, 2023
@bartlomieju bartlomieju deleted the kv_constructor branch May 3, 2023 21:08
levex pushed a commit that referenced this pull request May 4, 2023
@lucacasonato @bartlomieju @levex
fix(ext/kv): throw on the Kv constructor (#18978)
675aa94 
Closes #18963

---------

Co-authored-by: Bartek Iwańczuk <biwanczuk@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju left review comments

@ry ry ry approved these changes

@losfair losfair Awaiting requested review from losfair

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Usability Kv class
3 participants
@lucacasonato @ry @bartlomieju