Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): rebuild when JS sources for snapshotting change #18976

Merged
merged 1 commit into from
May 3, 2023
Merged

fix(core): rebuild when JS sources for snapshotting change #18976

merged 1 commit into from
May 3, 2023

Conversation

bartlomieju
Copy link
Member

I omitted it by accident.

@bartlomieju bartlomieju requested review from dsherret and crowlKats May 3, 2023 15:59
@bartlomieju bartlomieju enabled auto-merge (squash) May 3, 2023 16:00
dsherret
dsherret approved these changes May 3, 2023
View reviewed changes
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bartlomieju bartlomieju merged commit 246569f into denoland:main May 3, 2023
@bartlomieju bartlomieju deleted the rebuild_on_script_changes branch May 3, 2023 16:56
levex pushed a commit that referenced this pull request May 4, 2023
@bartlomieju @levex
fix(core): rebuild when JS sources for snapshotting change (#18976)
6526b10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsherret dsherret dsherret approved these changes

@crowlKats crowlKats Awaiting requested review from crowlKats

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bartlomieju @dsherret