feat(node/crypto): Diffie Hellman Support #18943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
levex
commented
May 1, 2023
| @@ -800,6 +801,30 @@ pub fn op_node_dh_generate( | |||
| dh_generate(prime, prime_len, generator) | |||
| } | |||
|
|
|||
| // TODO(lev): This duplication should be avoided. | |||
There was a problem hiding this comment.
@littledivy any ideas on how to avoid this duplication?
levex
commented
May 1, 2023
levex
commented
May 1, 2023
39 tasks
levex
commented
May 1, 2023
092c645 to
1c32537
Compare
levex
added a commit
that referenced
this pull request
May 18, 2023
Support crypto.DiffieHellman class in ext/node/crypto
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support crypto.DiffieHellman class in ext/node/crypto