Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(runtime): Add Deno. prefix for registered symbols #18086

Merged
merged 2 commits into from
Mar 9, 2023
Merged

fix(runtime): Add Deno. prefix for registered symbols #18086

merged 2 commits into from
Mar 9, 2023

Conversation

petamoriken
Copy link
Contributor

When using Symbol.for in Deno internal code, we should prefix them with Deno.

dsherret
dsherret approved these changes Mar 9, 2023
View reviewed changes
Copy link
Member

@dsherret dsherret left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When using Symbol.for in Deno internal code, we should prefix them with Deno.

Definitely. LGTM.

@dsherret dsherret enabled auto-merge (squash) March 9, 2023 04:06
@dsherret dsherret merged commit 521cb4c into denoland:main Mar 9, 2023
@petamoriken petamoriken changed the title fix(rumtime): Add Deno. prefix for registered symbols fix(runtime): Add Deno. prefix for registered symbols Mar 9, 2023
@petamoriken petamoriken deleted the fix/use-prefix-for-registered-symbols branch March 9, 2023 04:10
kt3k pushed a commit that referenced this pull request Mar 10, 2023
@petamoriken @kt3k
fix(rumtime): Add Deno. prefix for registered symbols (#18086)
cd9f11a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsherret dsherret dsherret approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@petamoriken @dsherret