Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: move setting up Deno namespace to snapshot time #18067

Merged
merged 1 commit into from
Mar 8, 2023

Conversation

bartlomieju
Copy link
Member

No need to do it on startup every time.

@bartlomieju bartlomieju requested a review from littledivy March 7, 2023 21:38
@bartlomieju
Copy link
Member Author

Merge on approval @littledivy

Copy link
Member

@littledivy littledivy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@littledivy littledivy merged commit 9eb987e into denoland:main Mar 8, 2023
@ry
Copy link
Member

ry commented Mar 8, 2023

How much did this improve things?

@bartlomieju
Copy link
Member Author

How much did this improve things?

0.1ms on my machine

@bartlomieju bartlomieju deleted the perf_bootstrap branch March 8, 2023 11:42
kt3k pushed a commit that referenced this pull request Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants