Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): prevent isolate drop for CLI main worker #18059

Merged
merged 12 commits into from
Mar 8, 2023
Merged

feat(core): prevent isolate drop for CLI main worker #18059

merged 12 commits into from
Mar 8, 2023

Conversation

littledivy
Copy link
Member

@littledivy littledivy commented Mar 7, 2023 •
edited
Loading 

Benchmark 1: deno run -A ../empty.js
  Time (mean ± σ):      20.5 ms ±   0.5 ms    [User: 13.4 ms, System: 5.1 ms]
  Range (min … max):    19.8 ms …  24.0 ms    119 runs

Benchmark 2: target/release/deno run -A ../empty.js
  Time (mean ± σ):      18.8 ms ±   0.3 ms    [User: 13.0 ms, System: 4.9 ms]
  Range (min … max):    18.3 ms …  19.9 ms    129 runs

@littledivy littledivy requested a review from bartlomieju March 7, 2023 03:31
bartlomieju
bartlomieju reviewed Mar 7, 2023
View reviewed changes
cli/worker.rs Outdated Show resolved Hide resolved
bartlomieju
bartlomieju approved these changes Mar 7, 2023
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's try this

@littledivy littledivy merged commit 0cce9c2 into denoland:main Mar 8, 2023
@bartlomieju bartlomieju deleted the isolate_leak_core branch March 8, 2023 16:57
kt3k pushed a commit that referenced this pull request Mar 10, 2023
@littledivy @bartlomieju @kt3k
feat(core): prevent isolate drop for CLI main worker (#18059)
c396957 
```
Benchmark 1: deno run -A ../empty.js
  Time (mean ± σ):      20.5 ms ±   0.5 ms    [User: 13.4 ms, System: 5.1 ms]
  Range (min … max):    19.8 ms …  24.0 ms    119 runs

Benchmark 2: target/release/deno run -A ../empty.js
  Time (mean ± σ):      18.8 ms ±   0.3 ms    [User: 13.0 ms, System: 4.9 ms]
  Range (min … max):    18.3 ms …  19.9 ms    129 runs
  ```

---------

Co-authored-by: Bartek Iwańczuk <biwanczuk@gmail.com>
ry added a commit that referenced this pull request Mar 13, 2023
@ry
Revert "feat(core): prevent isolate drop for CLI main worker (#18059)"
e48c702 
This reverts commit 0cce9c2.
bartlomieju pushed a commit that referenced this pull request Mar 13, 2023
@ry
Revert "feat(core): prevent isolate drop for CLI main worker (#18059)" (
224cff7 
#18157)

Fixes #18120
#18137
denoland/fresh#1073

This reverts commit 0cce9c2.
kt3k pushed a commit that referenced this pull request Mar 16, 2023
@ry @kt3k
Revert "feat(core): prevent isolate drop for CLI main worker (#18059)" (
c370f9e 
#18157)

Fixes #18120
#18137
denoland/fresh#1073

This reverts commit 0cce9c2.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@littledivy @bartlomieju