fix(check): include dts files in tsc roots #18026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aapoalas
approved these changes
Mar 5, 2023
|
Just dropping a note. Not sure if related, but when upgrading from More info in new issue #18117 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently declaration files aren't included in type checking unless as a dependency of a module. This affects entrypoint
.d.tsmodules, theX-TypeScript-Types/<reference types="./foo.d.ts" />of a JS entrypoint module and doc tests of untagged code blocks within a.d.tsmodule.The last one exposed that there were some untagged code blocks in
lib.deno.ns.d.tswhich would be wrongly checked in ambient mode due to the inherited virtual file extension being.d.ts. I've added those tags and also removed the unsafe default which causes that to happen.