Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: lazily surface errors in package.json deps parsing #17974

Merged
merged 11 commits into from
Mar 3, 2023
Merged

fix: lazily surface errors in package.json deps parsing #17974

merged 11 commits into from
Mar 3, 2023

Conversation

dsherret
Copy link
Member

Closes #17941

@dsherret dsherret requested a review from bartlomieju February 28, 2023 21:24
bartlomieju
bartlomieju approved these changes Mar 2, 2023
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsherret dsherret merged commit 84bafd1 into denoland:main Mar 3, 2023
@dsherret dsherret deleted the fix_lazy_surface_errors_package_json branch March 3, 2023 22:27
@dsherret dsherret mentioned this pull request Mar 9, 2023
Closed
kt3k pushed a commit that referenced this pull request Mar 10, 2023
@dsherret @kt3k
fix: lazily surface errors in package.json deps parsing (#17974)
483caf2 
Closes #17941
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Lazily surface package.json dependency entry errors
2 participants
@dsherret @bartlomieju