fix(runtime): Extract error code for all OS error variants #17958
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in #17719 made all
read_file
methods returnErrorData::Custom
instead of the originalErrorData::Os
.This is correct and unified behavior, however problematic at the same time, as
get_io_error_code
is not implemented for all possibleErrorKind
variants.In order to work around this, the newly created error is wrapped in
anyhow::Error
and the originalstd::io::Error
is provided as its context. This makes a downcasting inget_error_code
successful and allowsget_os_error_code
to be used for code extraction instead of problematicget_io_error_code
.File in question: https://github.com/denoland/deno/blob/main/core/error_codes.rs
It also changes error format from (
err, desc
toerr: desc
).Note that on Windows,
EISDIR
is reported asENOENT
due to Deno using libuv mappings (Windows code for this is267
) - https://github.com/libuv/libuv/blob/master/src/win/error.cFixes #17950