feat(ext/ffi): Make External pointers keep reference to V8 buffer #17955
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously when pointers were simply numbers, there was no way for a pointer number created from a buffer to keep the original buffer alive. This risked
Deno.UnsafePointer.of()
created pointers becoming dangling if the user did not manually make sure to save the original buffer somewhere.I have personally run into this previously, to disastrous (segfaulty) results. Based on this I felt the need to explicitly warn of this issue on the Denonomicon: https://denonomicon.deno.dev/types/pointers#dangling-pointers.
Now that pointers are objects themselves, we can get rid of this issue by using a
WeakMap
to hold theof()
buffer parameter with the pointer object acting as the key. This ensures that the buffer stays alive as long as the pointer object does, while holding a weak reference to the pointer object itself to avoid a memory leak.