Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(npm): support bare specifiers from package.json in more subcommands and language server #17891

Merged
merged 11 commits into from
Feb 23, 2023
Merged

feat(npm): support bare specifiers from package.json in more subcommands and language server #17891

merged 11 commits into from
Feb 23, 2023

Conversation

dsherret
Copy link
Member

@dsherret dsherret commented Feb 23, 2023 •
edited
Loading

This is missing LSP tests.

@dsherret dsherret changed the title fix(npm): various fixes for package.json bare specifiers feat(npm): support bare specifiers from package.json in more subcommands Feb 23, 2023
@dsherret dsherret changed the title feat(npm): support bare specifiers from package.json in more subcommands feat(npm): support bare specifiers from package.json in more subcommands and language server Feb 23, 2023
@dsherret dsherret marked this pull request as ready for review February 23, 2023 07:40
@dsherret dsherret requested a review from bartlomieju February 23, 2023 07:40
@dsherret dsherret added this to the 1.31 milestone Feb 23, 2023
bartlomieju
bartlomieju approved these changes Feb 23, 2023
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsherret dsherret merged commit 344317e into denoland:main Feb 23, 2023
@dsherret dsherret deleted the fix_various_fixes_bare_specifiers branch February 23, 2023 15:58
@dsherret dsherret mentioned this pull request Feb 23, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.31
Development

Successfully merging this pull request may close these issues.
2 participants
@dsherret @bartlomieju