fix(npm): resolve node_modules dir relative to package.json instead of cwd #17885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsherret
commented
Feb 22, 2023
| @@ -524,6 +535,14 @@ impl ConfigFile { | |||
| /// Filenames that Deno will recognize when discovering config. | |||
| const CONFIG_FILE_NAMES: [&str; 2] = ["deno.json", "deno.jsonc"]; | |||
|
|
|||
| // todo(dsherret): in the future, we should enforce all callers | |||
| // to provide a resolved path | |||
There was a problem hiding this comment.
What I've done in other projects is introduced a ResolvedPath struct, then force resolving that once and passing it around.
There was a problem hiding this comment.
That's a very good idea, we should do the same
dsherret
commented
Feb 22, 2023
cli/tests/testdata/run/with_package_json/no_deno_json/sub_dir/main.js
Outdated
Show resolved
Hide resolved
dsherret
commented
Feb 22, 2023
| } | ||
|
|
||
| Ok(()) | ||
| } |
There was a problem hiding this comment.
This was taken from elsewhere in the CLI.
bartlomieju
approved these changes
Feb 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.