Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: start caching npm package version's "bin" entry from npm registry #17881

Merged
merged 3 commits into from
Feb 22, 2023
Merged

feat: start caching npm package version's "bin" entry from npm registry #17881

merged 3 commits into from
Feb 22, 2023

Conversation

dsherret
Copy link
Member

This is to start saving this entry in people's cache directory.

@dsherret dsherret requested a review from bartlomieju February 22, 2023 16:14
dsherret
dsherret commented Feb 22, 2023
View reviewed changes
cli/npm/registry.rs Outdated Show resolved Hide resolved
@dsherret dsherret marked this pull request as draft February 22, 2023 16:28
@dsherret dsherret marked this pull request as ready for review February 22, 2023 16:45
bartlomieju
bartlomieju approved these changes Feb 22, 2023
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsherret dsherret merged commit 9b8992d into denoland:main Feb 22, 2023
@dsherret dsherret deleted the feat_save_bin_entry_npm_package_version_info branch February 22, 2023 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dsherret @bartlomieju