Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: use ops for node:crypto ciphers #17819

Merged
merged 6 commits into from
Feb 20, 2023

Conversation

littledivy
Copy link
Member

@littledivy littledivy commented Feb 19, 2023

Towards #17809

@bartlomieju
Copy link
Member

This PR lowers the startup time for me from 23.7ms to 23ms

@littledivy littledivy marked this pull request as ready for review February 20, 2023 13:41
@littledivy littledivy changed the title [WIP] perf(ext/node): port crypto cipher to rust ops perf(ext/node): port crypto cipher to rust ops Feb 20, 2023
@littledivy littledivy changed the title perf(ext/node): port crypto cipher to rust ops perf: use ops for node:crypto ciphers Feb 20, 2023
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@littledivy littledivy merged commit ea7ca00 into denoland:main Feb 20, 2023
@bartlomieju bartlomieju deleted the port_crypto_browserify branch February 20, 2023 17:11
hardfist pushed a commit to hardfist/deno that referenced this pull request Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants