fix(ops): Always close cancel handles for read_async/write_async #17736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xt_async and write_file_async
aapoalas
approved these changes
Feb 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17734
It'd be also possible to fix it inside
40_read_file.jsand40_write_file.jsby callingcore.tryClose(cancelRid)prior to removing the handler inoptions.signal[abortSignal.remove](abortHandler), but I think this is te more reasonable place.I found 3 incorrect tests that I fixed along the way (they used
readFileinstead ofreadTextFile.There's also a naming inconsistency, as
readfileandreadfile_textare written as joined-words, whereaswrite_fileis separated. Didn't want to touch that here, as not sure what are the implications of such a change in the codebase.