Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): don't allow to import internal code is snapshot is loaded #17694

Merged
merged 2 commits into from
Feb 8, 2023
Merged

fix(core): don't allow to import internal code is snapshot is loaded #17694

merged 2 commits into from
Feb 8, 2023

Conversation

bartlomieju
Copy link
Member

Addressing Luca concerns from #17648 (comment)

@bartlomieju bartlomieju merged commit bef5041 into denoland:main Feb 8, 2023
@bartlomieju bartlomieju deleted the internal_code_disable_loader branch February 8, 2023 17:14
@nayeemrmn nayeemrmn mentioned this pull request May 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucacasonato lucacasonato lucacasonato approved these changes

@crowlKats crowlKats Awaiting requested review from crowlKats

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bartlomieju @lucacasonato